Fix: Multiple Windows-related issues - focus loss, CI failures, and hanging processes #2762

winst0niuss · 2025-11-23T16:12:16Z

This PR addresses multiple issues affecting Windows platform and tab management:

Issues Fixed

1. Focus loss when opening new tabs with redirects (Issue #2761)

Problem: Focus randomly remained on the original tab approximately 40-60% of the time when clicking links that open new tabs with target="_blank" and perform multiple redirects (particularly in OAuth/SSO authentication flows).

Root Cause: The implementation used pages[0] from Chrome DevTools Protocol's target list, which didn't guarantee correct tab order and failed to account for targets changing during redirects.

Solution: A two-phase approach:

Optimistic path: Waits 500ms for redirect stabilization, then attempts direct connection to the exact targetId from the targetCreated event with explicit tab activation
Fallback path: If redirects changed the targetId, searches for targets opened from the same openerId and activates the matching target

Commits: 08328e1, 0436dd2

2. Windows CI test failures

Problem: CI tests failing on Windows due to line ending issues and test race conditions.

Solution:

Added .gitattributes for line ending normalization
Fixed race condition in write.test.js

Commit: 95d7c07

3. Hanging Chrome processes after closeBrowser() on Windows

Problem: After running tests, Chrome renderer and GPU processes remained running on Windows, consuming system resources.

Root Cause: Standard SIGTERM/SIGKILL signals don't kill child processes on Windows, leaving orphaned Chrome subprocesses.

Solution: Replaced manual process killing with tree-kill library to ensure the entire process tree is terminated on all platforms. This prevents orphaned Chrome processes across Windows, Linux, and macOS.

Commit: 79af9c9

Changed Files

lib/connection.js - targetCreated event handler improvements
lib/browser/launcher.js - closeBrowser() with tree-kill
.gitattributes - line ending normalization
test/unit-tests/write.test.js - race condition fix
package.json - added tree-kill dependency

The targetCreated event handler was incorrectly switching to the first available page (pages[0]) instead of the newly created target. This caused a race condition where focus would sometimes remain on the old tab when clicking links with target="_blank" or window.open(). The fix uses the correct target ID from the event parameter (newTarget.targetInfo.targetId) instead of fetching all pages and selecting the first one. Signed-off-by: winst0niuss <chumachenko.vadym@gmail.com>

Signed-off-by: winst0niuss <chumachenko.vadym@gmail.com>

This reverts commit 2f8eadf. Signed-off-by: winst0niuss <chumachenko.vadym@gmail.com>

- Add 500ms delay to wait for authentication redirects to complete - Try direct connection to targetId from event first (optimistic path) - Fallback to openerId search if target changed during redirects - Use switchBrowserContext() for explicit tab activation - Add detailed logging for debugging failed connections The previous approach used pages[0] which did not guarantee correct tab order from CDP. This caused focus to randomly stay on the old tab when clicking links with target='_blank' that trigger multiple redirects. The new implementation: 1. Waits for redirects to stabilize (500ms) 2. Attempts direct connection to the exact targetId from the event 3. Falls back to searching by openerId if redirects changed the targetId 4. Explicitly activates the target using switchBrowserContext() This ensures reliable focus switching even with complex authentication flows involving multiple redirects. Signed-off-by: winst0niuss <chumachenko.vadym@gmail.com>

Split pages.find() call across multiple lines to comply with Biome formatting rules. Signed-off-by: winst0niuss <chumachenko.vadym@gmail.com>

This commit addresses two Windows-specific CI failures that are unrelated to PR getgauge#2762: 1. **Line endings issue**: Added .gitattributes to enforce LF line endings across all platforms. Without this, Git on Windows converts LF to CRLF (when core.autocrlf=true), causing Biome linter to fail. 2. **Test race condition**: Fixed test/unit-tests/write.test.js:214 where closeBrowser() was called without await. This caused the browser to not fully close before removeFile() attempted to delete write.html, resulting in "EBUSY: resource busy or locked" on Windows. Changes: - Add .gitattributes with "* text=auto eol=lf" to normalize line endings - Fix write.test.js after() hook to await closeBrowser() before removeFile() - Reorder operations: close browser first, then remove file Fixes Windows CI test failures in the main repository. Signed-off-by: winst0niuss <chumachenko.vadym@gmail.com>

winst0niuss · 2025-11-24T08:13:00Z

@zabil Re-run tests please

- Add targetExists() helper to verify target before connection attempts - Check target existence after redirect delay to avoid connecting to closed targets - Handle ECONNRESET gracefully as expected error during redirects - Avoid unnecessary retries on non-existent targets - Improve fallback reliability when target changes during redirects The previous implementation attempted to connect to targetId from the targetCreated event without checking if it still exists. With multiple redirects, the browser may close intermediate targets, causing ECONNRESET errors when initCRI() tries to establish a CDP connection. The new approach verifies target existence first, preventing wasted connection attempts and providing better error handling for redirect chains. Signed-off-by: winst0niuss <chumachenko.vadym@gmail.com>

Replaced manual SIGTERM/SIGKILL process killing with tree-kill library to ensure entire process tree is terminated on all platforms. This prevents orphaned Chrome renderer and GPU processes on Windows. Signed-off-by: winst0niuss <chumachenko.vadym@gmail.com>

winst0niuss · 2025-11-24T13:47:49Z

Ready for tests and review

When closing the browser, if a page has a beforeunload event handler, Taiko would crash with 'There is no handler registered for beforeunload popup'. This fix adds a flag to automatically accept beforeunload dialogs during browser closure, preventing the crash while still allowing explicit beforeunload handling during normal operation. Fixes getgauge#2752 Signed-off-by: winst0niuss <chumachenko.vadym@gmail.com>

zabil · 2025-11-26T09:18:10Z

lib/browser/launcher.js

 const { setBrowserOptions, defaultConfig } = require("../config");
 const { eventHandler } = require("../eventBus");
 const util = require("node:util");
+const kill = require("tree-kill");


I am not sure about this library. The last update was 6 years ago
https://www.npmjs.com/package//tree-kill

I have doubts about this lib too, but currently the browser won't close on Windows (that's why we're stuck on Chromium 120.xxx).

The tree-kill package hasn't been updated in 6 years, raising maintenance and security concerns. Reverting to the original browser process termination approach using process.kill(). This reverts the process killing changes from commit 5bbafcc. Signed-off-by: winst0niuss <chumachenko.vadym@gmail.com>

winst0niuss · 2025-11-26T12:50:54Z

@zabil, I've reverted the tree-kill dependency changes

gaugebot · 2025-12-01T14:03:38Z

@winst0niuss Thank you for contributing to taiko. Your pull request has been labeled as a release candidate 🎉🎉.

Merging this PR will trigger a release.

Please bump up the version as part of this PR.

Instructions to bump the version can found at CONTRIBUTING.md

If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done.

Signed-off-by: winst0niuss <chumachenko.vadym@gmail.com>

winst0niuss · 2025-12-01T17:44:18Z

@zabil , re-run tests please

Fix beforeunload handler crash during browser closure

Signed-off-by: winst0niuss <chumachenko.vadym@gmail.com>

winst0niuss · 2025-12-04T06:30:02Z

@zabil , re-run tests please

winst0niuss added 6 commits November 23, 2025 09:52

chore: trigger CI

042956f

Signed-off-by: winst0niuss <chumachenko.vadym@gmail.com>

Revert "Fix focus loss when clicking links that open new tabs"

66d2dee

This reverts commit 2f8eadf. Signed-off-by: winst0niuss <chumachenko.vadym@gmail.com>

Fix Biome linting: reformat long line in targetCreated handler

a686b2c

Split pages.find() call across multiple lines to comply with Biome formatting rules. Signed-off-by: winst0niuss <chumachenko.vadym@gmail.com>

winst0niuss added 2 commits November 24, 2025 16:27

winst0niuss force-pushed the master branch from 79af9c9 to 5bbafcc Compare November 24, 2025 12:58

winst0niuss changed the title ~~Fix: Resolve focus loss when opening new tabs with redirects~~ Fix: Multiple Windows-related issues - focus loss, CI failures, and hanging processes Nov 24, 2025

winst0niuss and others added 2 commits November 24, 2025 23:30

Merge branch 'master' into master

c1156b5

zabil reviewed Nov 26, 2025

View reviewed changes

zabil added the ReleaseCandidate label Dec 1, 2025

winst0niuss added 2 commits December 1, 2025 18:30

Bump version 1.4.7

3be2b64

Signed-off-by: winst0niuss <chumachenko.vadym@gmail.com>

Bump version 1.4.7

710dfc3

Signed-off-by: winst0niuss <chumachenko.vadym@gmail.com>

winst0niuss force-pushed the master branch from 4f9a906 to 710dfc3 Compare December 1, 2025 14:38

zabil approved these changes Dec 1, 2025

View reviewed changes

winst0niuss added 2 commits December 2, 2025 16:00

Merge pull request #2 from winst0niuss/fix/beforeunload-on-close

b10662f

Fix beforeunload handler crash during browser closure

Revert lint-staged formatting to single line

d364984

Signed-off-by: winst0niuss <chumachenko.vadym@gmail.com>

winst0niuss force-pushed the master branch from 53fb1f9 to d364984 Compare December 2, 2025 12:42

zabil merged commit 5dcb236 into getgauge:master Dec 5, 2025
11 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix: Multiple Windows-related issues - focus loss, CI failures, and hanging processes #2762

Fix: Multiple Windows-related issues - focus loss, CI failures, and hanging processes #2762

Uh oh!

winst0niuss commented Nov 23, 2025 •

edited

Loading

Uh oh!

winst0niuss commented Nov 24, 2025

Uh oh!

winst0niuss commented Nov 24, 2025

Uh oh!

zabil Nov 26, 2025

Uh oh!

winst0niuss Nov 26, 2025

Uh oh!

winst0niuss commented Nov 26, 2025 •

edited

Loading

Uh oh!

gaugebot bot commented Dec 1, 2025

Uh oh!

winst0niuss commented Dec 1, 2025

Uh oh!

winst0niuss commented Dec 4, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

Fix: Multiple Windows-related issues - focus loss, CI failures, and hanging processes #2762

Fix: Multiple Windows-related issues - focus loss, CI failures, and hanging processes #2762

Uh oh!

Conversation

winst0niuss commented Nov 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issues Fixed

1. Focus loss when opening new tabs with redirects (Issue #2761)

2. Windows CI test failures

3. Hanging Chrome processes after closeBrowser() on Windows

Changed Files

Uh oh!

winst0niuss commented Nov 24, 2025

Uh oh!

winst0niuss commented Nov 24, 2025

Uh oh!

zabil Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

winst0niuss Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

winst0niuss commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gaugebot bot commented Dec 1, 2025

Please bump up the version as part of this PR.

Uh oh!

winst0niuss commented Dec 1, 2025

Uh oh!

winst0niuss commented Dec 4, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

winst0niuss commented Nov 23, 2025 •

edited

Loading

winst0niuss commented Nov 26, 2025 •

edited

Loading